Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace (defunct) Travis with Github Actions #141

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Replace (defunct) Travis with Github Actions #141

merged 6 commits into from
Sep 14, 2023

Conversation

jelmervdl
Copy link
Collaborator

No description provided.

@jelmervdl jelmervdl marked this pull request as ready for review September 14, 2023 08:46
XapaJIaMnu
XapaJIaMnu approved these changes Sep 14, 2023
View reviewed changes
Copy link

@XapaJIaMnu XapaJIaMnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add minimum python version 3.8, as well add that to the pypy build, since we don't actually test anything older than 3.8

@jelmervdl
Add minimum version
b8169ed 
Todo: Also bump version number as this is technically breaking compatibility
@jelmervdl
Copy link
Collaborator Author

I didn't add pypy3.8 because it is no longer supported: https://www.pypy.org/download.html

Re minimum version: I've added it, but before we release, we should bump the version number as this is technically breaking backwards compatibility.

@jelmervdl jelmervdl merged commit 1b161ea into master Sep 14, 2023
15 checks passed
@jelmervdl jelmervdl deleted the github-workflow branch September 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XapaJIaMnu XapaJIaMnu XapaJIaMnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelmervdl @XapaJIaMnu